deprecated linalg::Make_uniform and linalg::Make_normal#747
Open
manuschneider wants to merge 1 commit intomasterfrom
Open
deprecated linalg::Make_uniform and linalg::Make_normal#747manuschneider wants to merge 1 commit intomasterfrom
manuschneider wants to merge 1 commit intomasterfrom
Conversation
manuschneider
force-pushed
the
deprecate_Make_functions
branch
from
5b9a69b to
8b82396
Compare
manuschneider
force-pushed
the
deprecate_Make_functions
branch
from
8b82396 to
f4befdf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 32.35% 35.25% +2.90%
==========================================
Files 215 214 -1
Lines 36363 33091 -3272
Branches 14597 13194 -1403
==========================================
- Hits 11764 11666 -98
+ Misses 22659 19511 -3148
+ Partials 1940 1914 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IvanaGyro
reviewed
Mar 17, 2026
| auto UT = UniTensor(bonds, labels, row_rank, dtype, device, is_diag); | ||
| double low = -1000, high = 1000; | ||
| int rnd_seed = 0; | ||
| random::Make_uniform(UT, low = -1000, high = 1000, rnd_seed); |
Collaborator
There was a problem hiding this comment.
I remember we don't assure that C++ API is stable. These functions are not bind to Python. We can just remove them without notification.
Contributor
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #746