Fix CME in EntityVengeanceSpirit.canSpawnNew during dimension unload#1182
Merged
rubensworks merged 2 commits intomaster-1.21-ltsfrom Apr 8, 2026
Merged
Conversation
Coverage Report for CI Build 24149285071Coverage decreased (-0.002%) to 28.5%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
…New during dimension unload Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/70f33748-f5e4-44bb-b0ba-4b476bbb08b1 Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ConcurrentModificationException in EntityVengeanceSpirit.canSpawnNew
Fix CME in EntityVengeanceSpirit.canSpawnNew during dimension unload
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mob dies during dimension teardown,
vengeanceEventfires andcanSpawnNewcallsWorldHelpers.foldArea → level.getBlockState(). OnServerLevel, this triggersServerChunkCache.runDistanceManagerUpdateson a DistanceManager whose ticket map is being concurrently modified, causing aConcurrentModificationException.Change
Added
level1.isLoaded(blockPos1)guard in thecanSpawnNewblock-scan lambda.Level.isLoaded()delegates togetChunkSource().hasChunk(), which checks loaded state without forcing a chunk load. Unloaded positions skip the spirit-blocker tag check (no blocker assumed).