Include build number in mod metadata version for non-releases#223
Draft
Include build number in mod metadata version for non-releases#223
Conversation
Agent-Logs-Url: https://github.com/CyclopsMC/CyclopsCore/sessions/461a7190-337e-4568-ad30-f4345f80818b Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rubensworks
April 9, 2026 06:09
View session
|
|
coverage: 30.857%. remained the same — copilot/add-build-number-to-mod-version into master-26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processResourceswas expanding${mod_version}inmods.toml/neoforge.mods.toml/fabric.mod.jsonusing the rawmod_versionproperty (e.g.1.25.5) rather thanproject.version, which already carries the build number suffix for non-releases (e.g.1.25.5-944).Change
buildSrc/src/main/groovy/multiloader-common.gradle: InprocessResources.expandProps, replacemod_version: mod_versionwithmod_version: project.version, so the full version string (including-<build_number>suffix) is written into mod metadata on CI builds, while tagged releases continue to produce the clean version.