Fix koji proxy group member concurrent issue, use API to update member instead of override#2507
Merged
yma955 merged 2 commits intoCommonjava:masterfrom Sep 2, 2025
Merged
Fix koji proxy group member concurrent issue, use API to update member instead of override#2507yma955 merged 2 commits intoCommonjava:masterfrom
yma955 merged 2 commits intoCommonjava:masterfrom
Conversation
…r instead of override
sswguo
reviewed
Aug 27, 2025
|
|
||
| storeDataManager.storeArtifactStore( targetGroup, changeSummary, false, true, new EventMetadata() ); | ||
| // Use repo service API to append the member of group instead of to override during target group update. | ||
| storeDataManager.addConstituentToGroup( targetGroup.getKey(), buildRepo.getKey() ); |
Member
There was a problem hiding this comment.
If we have the addConstituentToGroup, is the above storeArtifactStore still needed ?
Member
Author
Member
There was a problem hiding this comment.
Yeah, that's what we discussed earlier, to replace that part with the specific endpoint.
Member
Author
|
@sswguo This passes for build. Any other comment? I'll merge if all looks good. |
Member
LGTM. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.