Skip to content

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 5 | Implement laptop allocation #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aydaeslami wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 5 | Implement laptop allocation #300

aydaeslami wants to merge 6 commits into from

Conversation

@aydaeslami
Copy link

@aydaeslami aydaeslami commented Dec 12, 2025 •
edited
Loading

PR Checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Assign one laptop per person
  • Respect OS preference order
  • Sadness = preference index, or 100 if not listed
  • Do not reuse laptops
  • Minimise total sadness

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@aydaeslami aydaeslami added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module labels Dec 12, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 21, 2026
LonMcGregor
LonMcGregor reviewed Jan 21, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

laptop/myLaptop.py Outdated

def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> dict[Person, Laptop]:
allocateLp = {}
lpNewList = laptops.copy()
Copy link

@LonMcGregor LonMcGregor Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these variable names clear about what they represent?

Copy link

@LonMcGregor LonMcGregor Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You marked this comment as resolved, but I am still not sure if some of the variable names in this function are clear. allocateLp, lpNewList and lp could maybe be improved. I assume lp means laptop, from context?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 21, 2026
@aydaeslami aydaeslami added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
LonMcGregor
LonMcGregor reviewed Feb 10, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. please see my comment in this review

laptop/myLaptop.py Outdated

def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> dict[Person, Laptop]:
allocateLp = {}
lpNewList = laptops.copy()
Copy link

@LonMcGregor LonMcGregor Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You marked this comment as resolved, but I am still not sure if some of the variable names in this function are clear. allocateLp, lpNewList and lp could maybe be improved. I assume lp means laptop, from context?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@aydaeslami aydaeslami added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
LonMcGregor
LonMcGregor reviewed Feb 10, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It's much more obvious at first glance what these variables are doing now. Well done

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aydaeslami @LonMcGregor