London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 4 | Implement Shell tools in python #270

aydaeslami · 2025-12-01T17:13:11Z

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

This PR includes my solutions to simulate several shell tools in Python.
I used the argparse module to re-implement them.

DaryaShirokova

Great progress on this! Left a few comments here

DaryaShirokova · 2026-01-02T20:34:25Z

implement-shell-tools/cat/cat.py

+    description="Simple cat clone with -n and -b options",
+)
+
+counterNumber = 1


In python the usual code style is to use snake_case.

Thanks for pointing that out. I’ll update the variable.

DaryaShirokova · 2026-01-02T20:37:29Z

implement-shell-tools/cat/cat.py

+              print(counterNumber, arrText[i])
+              counterNumber += 1
+        else:
+            print(content)


Could you please wrap you logic into a method and run it using if __name__ == "__main__": approach? Ideally the program should not contain global vars, and having methods improves readability.

Thanks for the suggestion. I’ve moved the logic into functions, added a main() entry point using if name == "main": and removed global variables to improve readability.

DaryaShirokova · 2026-01-02T20:39:35Z

implement-shell-tools/cat/cat.py

+)
+
+counterNumber = 1
+parser.add_argument("-n", action="store_true", help="number all lines")


cat -n sample-files/1.txt, cat.py sample-files/ *.txt (including -n option) and cat -b sample-files/3.txt all show slightly different result from yours.

DaryaShirokova · 2026-01-02T20:41:07Z

implement-shell-tools/cat/cat.py

+for file_path in args.path:
+    with open(file_path, "r") as f:
+        content = f.read()
+        arrText = content.split("\n")


There is a method in python to read file into an array of lines directly.

Thank you for the suggestion. I’ll use the built-in method to read the file into a list of lines directly.

DaryaShirokova · 2026-01-02T20:42:03Z

implement-shell-tools/cat/cat.py

+        arrText = content.split("\n")
+
+        if args.b:
+            for i in range(len(arrText )):


You can potentially use enumerate here.

DaryaShirokova · 2026-01-02T20:49:55Z

implement-shell-tools/ls/ls.py

+parser.add_argument("path", nargs="?", default=".", help="The directory to list")
+args = parser.parse_args()
+
+


Again, formatting could be improved with ruff here or other formatters :)

DaryaShirokova · 2026-01-02T20:51:09Z

implement-shell-tools/ls/ls.py

+)
+
+parser.add_argument("-a", action="store_true", help="include hidden files")
+parser.add_argument("-1", dest="one" ,action="store_true", help="use a long listing format")


What do you mean by long listing format here?

Many thanks for your time and help.
I’ll update the help text to reflect that.

DaryaShirokova · 2026-01-02T20:51:45Z

implement-shell-tools/ls/ls.py

+import argparse
+import os
+
+def show_unhidden_files(listDir):


Can these two functions be merged into one using extra method param?

Thanks for the suggestion.
I merged them into a single function with an extra parameter.

DaryaShirokova · 2026-01-02T20:54:46Z

implement-shell-tools/wc/wc.py

+parser.add_argument("path", nargs="+", default=".", help="The file to count")
+args = parser.parse_args()
+
+if not args.l and not args.w and not args.c:


Can you rework this code to have less duplication, by using methods?

Thank you for your feedback, I’ve refactored the code to reduce duplication.

DaryaShirokova · 2026-01-02T20:56:42Z

implement-shell-tools/wc/wc.py

@@ -0,0 +1,66 @@
+import argparse
+parser = argparse.ArgumentParser(


Please enasure your output is the same as the one suggested for examples in the readme (it is ok if whitespaces are different in your output):

It must act the same as `wc` would, if run from the directory containing this README.md file, for the following command lines: * `wc sample-files/*` * `wc -l sample-files/3.txt` * `wc -w sample-files/3.txt` * `wc -c sample-files/3.txt` * `wc -l sample-files/*`

aydaeslami added 4 commits December 1, 2025 13:32

My Cat in Python

3383e76

change Cat description and create ls.py file

7ba19f8

MyLs in python

419f1db

MyWc in Python

37dc584

aydaeslami added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 1, 2025

DaryaShirokova reviewed Jan 2, 2026

View reviewed changes

DaryaShirokova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 2, 2026

Update files: cat/ls/wc

ae59977

aydaeslami added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026

		parser.add_argument("path", nargs="?", default=".", help="The directory to list")
		args = parser.parse_args()

		@@ -0,0 +1,66 @@
		import argparse
		parser = argparse.ArgumentParser(

Uh oh!

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 4 | Implement Shell tools in python #270

Are you sure you want to change the base?

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 4 | Implement Shell tools in python #270

Uh oh!

Conversation

aydaeslami commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaryaShirokova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aydaeslami commented Dec 1, 2025 •

edited

Loading