London | SDC-Nov-25 | Ikenna Agulobi | Sprint 2 | Jq

[ike-agu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

This Pr contains sprint 2 exercise on jq command.

[LonMcGregor]

Good work, I've left one comment where you could improve your solution.

Could you also check shell-pipelines? You don't need to include this directory in this PR

[LonMcGregor]

Can you build a solution that would work no matter how many lines of address there are?

[ike-agu]

@LonMcGregor , thanks for pointing it out. I just realised my solution was hard coded.
I have updated the jq command to use join(", ") so it works no matter how many lines of address there are.

[LonMcGregor]

Good work! If you can clean up the shell-pipelines files (they don't need to be here) this task will be complete

[ike-agu]

Hi @LonMcGregor, thank you for taking the time to review my PR and for pointing out the necessary changes. I’ve implemented the requested updates. When you have a moment, could you please take another look?

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[LonMcGregor]

Just a reminder - this is the JQ task,the bot might be getting confused because you have committed files from another task here. Can you remove them?

[ike-agu]

@LonMcGregor - I struggling to clear the shell pipelines directory from this PR

Just a reminder - this is the JQ task,the bot might be getting confused because you have committed files from another task here. Can you remove them?

[github-actions]

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[ike-agu]

@LonMcGregor - Thanks again for reviewing my PR. I have problems deleting the shell-pipelines directory.

The challenge I have:
I'm struggling to delete the shell-pipelines directory from this PR. I've done some debugging in my in local machine using the commands below but the directory is neither in my main branch nor my jq-exercise branch. I'm not sure how to delete it.

What I did:
git ls-tree -r --name-only HEAD | grep -E '^shell-pipelines(/|$)' || echo "Not in this branch"

Not in this branch

jq % git fetch origin git ls-tree -r --name-only origin/main | grep -E '^shell-pipelines(/|$)' || echo "Not in origin/main"

Not in origin/main

What I expected:
I expected to find the shell-pipelines directory either in my main branch or jq-exercise branch, so I can delete it and create a new commit.

How I solved the issue:
I created this new PR #327 which contains only the jq directory. My question is should I closed the old PR #252 and retain the new one?

[LonMcGregor]

@ike-agu If you've made a new Pr, you can close this old one. I will review the new one.