Skip to content

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
katarzynakaz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems #226

katarzynakaz wants to merge 2 commits into from

Conversation

@katarzynakaz
Copy link

@katarzynakaz katarzynakaz commented Nov 15, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Numbers systems done.

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@katarzynakaz katarzynakaz changed the title Glasgow | SDC | Katarzyna Kazimierczuk ? Sprint 1 Numbers systems Glasgow | SDC | Katarzyna Kazimierczuk | Sprint 1 Numbers systems Nov 15, 2025
@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

4 similar comments
@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@katarzynakaz katarzynakaz reopened this Feb 7, 2026
@katarzynakaz katarzynakaz marked this pull request as draft February 7, 2026 12:31
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz
Copy link
Author

katarzynakaz commented Feb 7, 2026

/title Glasgow | SDC | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems

@katarzynakaz katarzynakaz marked this pull request as ready for review February 7, 2026 12:38
@katarzynakaz katarzynakaz marked this pull request as draft February 7, 2026 12:38
@katarzynakaz katarzynakaz marked this pull request as ready for review February 7, 2026 12:39
@katarzynakaz katarzynakaz changed the title Glasgow | SDC | Katarzyna Kazimierczuk | Sprint 1 Numbers systems Glasgow | SDC | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@katarzynakaz katarzynakaz changed the title Glasgow | SDC | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 1 | Numbers systems Feb 7, 2026
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz katarzynakaz added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 11, 2026
LonMcGregor
LonMcGregor reviewed Feb 11, 2026
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@LonMcGregor LonMcGregor removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 11, 2026
@LonMcGregor LonMcGregor added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katarzynakaz @LonMcGregor