London | Jan-26 | Boualem Larbi Djebbour | Sprint 2 | feature/Form Controls #1164
Conversation
Removed form fields and added comments for future implementation.
created a webpage as required in the backlog
Updated testable criteria to reflect completed tasks.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
djebsoft
added
the
Needs Review
jenny-alexander
added
Review in progress
|
thank you for reviewing, what should I do now as you left no comment ? |
djebsoft
added
the
Needs Review
Form-Controls/index.html
Outdated
| </select> | ||
| </div> | ||
| <br> | ||
| <button type="submit">Sumbit</button> |
There was a problem hiding this comment.
Please check for a typo on the button.
Form-Controls/index.html
Outdated
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">Name</label> | ||
| <input type="text" name="name" id="name" required minlength="2" pattern="[A-Za-z\s]+"> |
There was a problem hiding this comment.
🤔 Your pattern might be a bit too restrictive. If I enter a name like 'Jean-Luc', I get a message telling me that my name doesn't follow the pattern.
Also, if you're going to use a pattern, it's a good idea to tell the user in the message, what the pattern in.
| <label for="colour">select colour</label> | ||
| <select name="colour" id="colour" required> | ||
| <option value="" disabled selected>Select a colour</option> | ||
| <option value="brown">brown</option> |
There was a problem hiding this comment.
For your colour options, try to follow the same naming convention for all options. Currently, 'brown' and 'yellow' start with a lowercase letter but 'Green' starts with uppercase letter.
|
Hi,Can you check the PR again? I forgot to submit my comments. Apologies!JenniferOn Feb 9, 2026, at 3:00 PM, boladjebsoft ***@***.***> wrote:djebsoft left a comment (CodeYourFuture/Module-Onboarding#1164)
thank you for reviewing, what should I do know as you left no comment ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
I made all the required changes except the first one about readme file updated as I can't see any update, I just ticked the 8 required boxes |
There are changes in the |
jenny-alexander
removed
the
Needs Review
djebsoft
added
the
Needs Review
|
Nice work @djebsoft 👍 |
jenny-alexander
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
creating form controls webpage.