-
-
Notifications
You must be signed in to change notification settings - Fork 419
Glasgow | 26-ITP-Jan | Joma Alrzini | Sprint 2 | Form- Control #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SlideGauge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, good form, just a request about name criteria being adjusted.
Form-Controls/index.html
Outdated
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[A-Za-z\s]{2,}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern will block real names like O'connor or Sklodowska-Curie. The initial assignment did not demand letters only.
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |

Learners, PR Template
Self checklist
Changelist
I have followed the PR structure for coursework
Questions
I have no question