Skip to content

Conversation

@Alrzini2025
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have followed the PR structure for coursework

Questions

I have no question

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit ae64337
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698a1c19491ea800085774c8
😎 Deploy Preview https://deploy-preview-1159--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 70 (🔴 down 16 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 7, 2026
Copy link

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good form, just a request about name criteria being adjusted.

id="name"
name="name"
required
pattern="[A-Za-z\s]{2,}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern will block real names like O'connor or Sklodowska-Curie. The initial assignment did not demand letters only.

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 7, 2026
@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants