London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Form Controls #1154

miriamjorna · 2026-02-06T20:12:53Z

London | Jan26ITP | Miriam Jorna | Sprint 2 | T-shirt form

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Homework for Sprint 2: HTML form. Now in a clean branch.

netlify · 2026-02-06T20:13:04Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`cebf3c9`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6989ffd08a41f50008f2e850
😎 Deploy Preview	https://deploy-preview-1154--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 88 (🟢 up 2 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan

Can you also take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?

Form-Controls/index.html

…and spaces are no longer valid input). Have put label tags on radio buttons as proposed. Put sizes in a table to make page shorter, so that Submit button doesn't run out of sight.

…dule-Onboarding into tshirt-form-clean

cjyuan

According to https://validator.w3.org/, there is an error in your code. Can you fix it?

cjyuan · 2026-02-09T05:58:16Z

Form-Controls/index.html

+ <p>
+    <label for="name">
+      Name: <input type="text" id="name" minlength="2" name="user_name" 
+      pattern="[A-Za-z]{2}" title="At least two letters are needed" required autofocus />


Have you tested this input field to see if it can correctly accept and reject the values as expected?

Ahhh... I did several times, but clearly not after the last change! Thanks for spotting that

cjyuan · 2026-02-09T05:58:52Z

Form-Controls/index.html

+<p>
+    <label for="email">
+      Email: <input type="email" id="email" name="user_email" required />
+    </label>
+  </p>


Can you improve the indentation of the code in this file?

Have changed this.
About line 50:
When I ask VSCode to autoformat it keeps changing my change on line 50 (into a more vertical listing as with Name) back into one line. This suggests I'm doing it wrong? I'm leaving it as autoformatted.
For clarity, the /> is now a >

The trailing slash / in <input ... /> is not needed in HTML.

Not sure what you meant by "more vertical listing".

Is this your concern?

<input type="email" id="email" name="user_email" required />

is changed to

<input type="email" id="email" name="user_email" required >

?

Both formats work.

Yes, that's what I did, and then VSCode keeps changing it back to one line. I tried the vertical form to find out if that would be what you meant by an improvement on the indentation.

Form-Controls/index.html

cjyuan · 2026-02-09T06:05:15Z

Form-Controls/index.html

+    <table>
+    <tr padding="30px">


It is a bad practice to use <table> for layout purpose. A normal approach would be to use CSS.

However, without CSS, we can still create enough spacing to reach 100 in Lighthouse accessibility score using some elements that can produce space/gap in HTML.

…oing colours earlier) - After validation removed a whole lot of empty slashes in /> and replaced with just > - Removed invalid padding code - Responded to comments in review Thank you for your patience

cjyuan · 2026-02-09T17:40:26Z

Changes look good enough.

There are several areas the code can be further improved. Can you share your code to ChatGPT and ask it for possible improvements?

I will mark this PR as complete first.

miriamjorna · 2026-02-09T23:20:35Z

Hurray and thank you!
I'm first going to use what little time I have left to try and make the deadline for onboarding, which has today been set for a week earlier (panic!). I will certainly revisit this after that.

hoimir added 9 commits February 6, 2026 20:07

wrote out reqs as comments

8063ee8

putting basic elements of the form in place

6374d90

basic form set up

6b2b9ef

Form scaffolding up

213f159

ticked off the boxes in the Readme file

af84015

added submit/reset buttons

f127fa5

in the correct branch

0dda10a

adapted meta description

80e4de5

Added "required" to sections

eb221fe

miriamjorna added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026

Merge branch 'main' into tshirt-form-clean

d6b3b93

miriamjorna mentioned this pull request Feb 6, 2026

London | Jan26ITP | Miriam Jorna | Sprint 2 | T-shirt form #1145

Closed

4 tasks

cjyuan reviewed Feb 6, 2026

View reviewed changes

Form-Controls/index.html Show resolved Hide resolved

Form-Controls/index.html Outdated Show resolved Hide resolved

Form-Controls/index.html Outdated Show resolved Hide resolved

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026

hoimir added 2 commits February 9, 2026 00:37

Enforced stricter validation on name, so that text needs to be used (…

257e760

…and spaces are no longer valid input). Have put label tags on radio buttons as proposed. Put sizes in a table to make page shorter, so that Submit button doesn't run out of sight.

Merge branch 'tshirt-form-clean' of https://github.com/miriamjorna/Mo…

b5508d5

…dule-Onboarding into tshirt-form-clean

miriamjorna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 9, 2026

cjyuan reviewed Feb 9, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 9, 2026

- Refactored the labelling on the T-shirt sizes as well (after only d…

cebf3c9

…oing colours earlier) - After validation removed a whole lot of empty slashes in /> and replaced with just > - Removed invalid padding code - Responded to comments in review Thank you for your patience

miriamjorna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 9, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 9, 2026

cjyuan added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Feb 9, 2026

miriamjorna mentioned this pull request Feb 11, 2026

London | ITP-January-26 | Onboarding | Miriam_Jorna miriamjorna/My-Coursework-Planner#43

Open

Uh oh!

London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Form Controls #1154

Are you sure you want to change the base?

London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Form Controls #1154

Conversation

miriamjorna commented Feb 6, 2026

London | Jan26ITP | Miriam Jorna | Sprint 2 | T-shirt form

Changelist

Uh oh!

netlify bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

miriamjorna Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

miriamjorna Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

miriamjorna Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Feb 9, 2026

Uh oh!

miriamjorna commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Feb 6, 2026 •

edited

Loading