Skip to content

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ayogit1 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Birmingham | 26-ITP-Jan | Ayodeji Ayorinde | Sprint 2 | Form Controls #1141

Ayogit1 wants to merge 9 commits into from

Conversation

@Ayogit1
Copy link

@Ayogit1 Ayogit1 commented Feb 5, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR contains the completed work on the Form Controls

Questions

@netlify
Copy link

netlify bot commented Feb 5, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 227025e
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6989eddef51593000741b15f
😎 Deploy Preview https://deploy-preview-1141--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 70 (🔴 down 16 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@Ayogit1
Copy link
Author

Ayogit1 commented Feb 5, 2026

@cjyuan, I closed the previous PRs as I could not change the title.
This is the new PR for Form Control and needs review.

@Ayogit1 Ayogit1 mentioned this pull request Feb 5, 2026
Open
3 tasks
@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

Can you address the inline comments I left on your previous PR? #1044

cjyuan
cjyuan reviewed Feb 5, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
@Ayogit1
Update index.html
a647e7a 
Removed multiple 'Required' since it is not necessary to use required on every radio button in the same group.
@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

I left these comments on your closed PR. Can you address them?
image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@Ayogit1 Ayogit1 mentioned this pull request Feb 7, 2026
Open
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
cjyuan
cjyuan reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an input element that would allow a user to submit the form data?

Form-Controls/index.html
<body>

<main>
<form action="/my-handling-form-page" method="post">
Copy link
Contributor

@cjyuan cjyuan Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why use POST method to submit the form data?

Copy link
Author

@Ayogit1 Ayogit1 Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't answer what I asked, and how did you resolve it?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 8, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 8, 2026

Can you address this comment?

image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 8, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 11, 2026

  • Your most recent commit modified files in the Wireframe folder. You should revert the changes in that folder or else the Validation bot will not let you use the "Needs Review" label.

  • I am still waiting for an explanation why you choose to use POST method in your form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ayogit1 @cjyuan