Skip to content

WestMidlands | 26-ITP-Jan | Seid Hagos| Sprint 2 | Feature/form control #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seiddhagoss wants to merge 7 commits into
base: main
Choose a base branch
from
Open

WestMidlands | 26-ITP-Jan | Seid Hagos| Sprint 2 | Feature/form control #1134

seiddhagoss wants to merge 7 commits into from

Conversation

@seiddhagoss
Copy link

@seiddhagoss seiddhagoss commented Feb 4, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I added pattern that accept letters, given only 3 different colour choices and every input is required must be filled.

@seiddhagoss
Refactor CSS styles and layout structure
4e66b5c 
Refactor CSS variables and layout styles for better organization and maintainability.
@seiddhagoss
Revise index.html for improved content and structure
41197c6 
Updated the content and structure of the index.html file to provide a more comprehensive overview of README files, wireframes, and Git branches.
@seiddhagoss
purpose of readme file
47f3580
@netlify
Copy link

netlify bot commented Feb 4, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2e318fe
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6988729e97cc8200084c68e2
😎 Deploy Preview https://deploy-preview-1134--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 94 (🔴 down 6 from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 66 (🔴 down 20 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
4 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@seiddhagoss seiddhagoss marked this pull request as draft February 5, 2026 10:39
@seiddhagoss seiddhagoss added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 6, 2026

You need to update the placeholder text in both the "Changelist" and the "Questions" sections in the PR description or else the validation bot will keep complaining and remove the "Needs Review" label.
image

cjyuan
cjyuan reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any implementation of the Form-Controls exercise in this PR. I only see changes made to some files that are not related to the Form-Controls exercise.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
3 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@seiddhagoss seiddhagoss marked this pull request as ready for review February 8, 2026 11:23
@github-actions

This comment has been minimized.

Sign in to view
@cjyuan
Copy link
Contributor

cjyuan commented Feb 8, 2026 •
edited
Loading

This branch is not clean as it contains changes in the Wireframe folder that is not related to the Form-Controls exercise.
(See my next comment for instructions to fix the problem).

@cjyuan
Copy link
Contributor

cjyuan commented Feb 8, 2026

I just take a look at your main branch and it has been modified (which you shouldn't).

You need to revert the changes on the main branch or else any new branches will also be polluted.

Alternatively, you can backup your code, delete your Onboarding repo, and then fork the repo again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

NotCoursework Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seiddhagoss @cjyuan