Skip to content

Glasgow | 26-ITP-Jan | Joma Alrzini | Sprint 1 | Wireframe #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alrzini2025 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Glasgow | 26-ITP-Jan | Joma Alrzini | Sprint 1 | Wireframe #1123

Alrzini2025 wants to merge 7 commits into from
+245 −95

Conversation

@Alrzini2025
Copy link

@Alrzini2025 Alrzini2025 commented Feb 3, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This is my first page of HTML

Questions

No question

@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Feb 3, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f5520bb
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698c92d7a28e7300089793a7
😎 Deploy Preview https://deploy-preview-1123--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 4, 2026
@Alrzini2025 Alrzini2025 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 4, 2026
cjyuan
cjyuan reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
cjyuan
cjyuan reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax errors and well indented. Good job.

One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

Wireframe/style.css Outdated
Comment on lines 19 to 23
* {
margin: 0;
padding: 0;
box-sizing: border-box;
}
Copy link
Contributor

@cjyuan cjyuan Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the indentation on this file?

Wireframe/index.html Outdated
Comment on lines 63 to 69
<button class="read-more-btn">READ MORE</button>
<p class="article-summary">A branch enables developers to implement changes, test new ideas,
and commit work independently. After completion and review, the branch is merged into
the main branch, commonly referred to as main or master. This process facilitates team
collaboration, version management, and maintains the stability of the main
codebase during ongoing development.</p>

Copy link
Contributor

@cjyuan cjyuan Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better match the given wireframe, can you

  • Show the article summary between the title and the "Read more" link, and then make the summary visible on page load
  • Change the "Read more" to a link (Note: supposedly when the user clicks the link, they will lead to another page3, but in this implementation you can use a placeholder URL)

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 11, 2026

Can you also address these requests:

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

  • Make the article summary visible on page load.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@Alrzini2025
Copy link
Author

Alrzini2025 commented Feb 11, 2026

I made he page footer is fixed to the bottom of the viewport
I made the article summary visible when loading the page

@Alrzini2025 Alrzini2025 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 11, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alrzini2025 @cjyuan