generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 26
Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 3 | Middleware #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nataliia74
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
Nataliia74:Middleware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import express from "express"; | ||
| import cors from "cors"; | ||
|
|
||
| const app = express(); | ||
|
|
||
| app.use(express.json()); | ||
| app.use(cors()); | ||
|
|
||
| function authenticationCheck(req, res, next) { | ||
| const username = req.header("X-Username"); | ||
|
|
||
| req.username = username ? username : null; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code works, but it would probably be more normal to see it written as either
or
A useful exercise would be to understand the difference between these two forms (and why the first one is better) |
||
| next(); | ||
| } | ||
|
|
||
| function bodyMessageCheck(req, res, next) { | ||
| let body = req.body; | ||
|
|
||
| if (!Array.isArray(body) || !body.every((item) => typeof item === "string")) { | ||
| return res.status(400).json({ error: "Body must be array strings." }); | ||
| } | ||
| req.bodyArray = body; | ||
| next(); | ||
| } | ||
|
|
||
| app.use(authenticationCheck); | ||
|
|
||
| app.post("/submit", bodyMessageCheck, (req, res) => { | ||
| const countArraySubjects = req.bodyArray.length; | ||
| const arraySubjects = req.bodyArray.join(", "); | ||
|
|
||
| const authMessage = req.username | ||
| ? `You are authenticated as: ${req.username}` | ||
| : `You are not authenticated`; | ||
|
|
||
| const bodyMessage = | ||
| countArraySubjects === 0 | ||
| ? `You have requested information about 0 subjects.` | ||
| : countArraySubjects === 1 | ||
| ? `You have requested information about 1 subject: ${arraySubjects}.` | ||
| : `You have requested information about ${countArraySubjects} subjects: ${arraySubjects}.`; | ||
|
|
||
| res.send(`${authMessage}\n\n${bodyMessage}`); | ||
| }); | ||
|
|
||
| app.listen(3000, () => console.log("Server running on http://localhost:3000")); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is hard. I would suggest that this isn't an authenticationCheck because it doesn't do anything different if the header isn't there. With a name with check in it I'd expect a 401 response if there isn't the required header