[SSF 160] - Improvements to FM Donation Management UI#125
Open
dburkhart07 wants to merge 4 commits intomainfrom
Open
[SSF 160] - Improvements to FM Donation Management UI#125dburkhart07 wants to merge 4 commits intomainfrom
dburkhart07 wants to merge 4 commits intomainfrom
Conversation
sam-schu
requested changes
Mar 11, 2026
Collaborator
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
Can we make it so that clicking into an empty validated input and then clicking out does not fill in a default value?
sam-schu
requested changes
Mar 11, 2026
Collaborator
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
- Could we either make it so that validation errors stop you from submitting the modal, or we show the backend validation errors in the failure alert like the pantry and manufacturer application pages? since currently, you can e.g. enter -1 into quantity and then immediately press submit and the feedback is confusing
- while we're here, can we quickly update the backend validation to require quantity to be an integer, not just a number?
- can we actually make the min for oz per item and donation value 0.01 to match the backend, sorry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #160
📝 Description
✔️ Verification
Smoke tested page
🏕️ (Optional) Future Work / Notes