Open
Conversation
dburkhart07
requested changes
Mar 9, 2026
|
Note for @sam-schu and @Yurika-Kan for future ticketing. We will likely need some form of proper checking to ensure the url is a dns-registered/reachable one. I initially suggested we implement it in the sanitization check, but this really wouldn't work, since we can't assume the url in the database is valid (e.g i publish a site, we save that as the url, then i take it down, and now the tracking link is not valid). To be safe, I think we should be checking each time we retrieve the order from the backend that the url is dns-registered (but something for a future ticket perhaps). If you have other thoughts let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-156
📝 Description
updateTrackingCostInfomethod inorder.service.ts✔️ Verification
wrote tests, tests pass
verified behavior in postman
🏕️ (Optional) Future Work / Notes