Open
Conversation
Juwang110
reviewed
Mar 8, 2026
Juwang110
left a comment
Juwang110
left a comment
There was a problem hiding this comment.
Honestly lgtm, one thing though. @sam-schu @Yurika-Kan I was going to comment to add test cases for these new bad request exceptions but it seems like approve/deny routes for both manufacturers and pantries don't have service tests. Should we add them here or is it fine?
Collaborator
|
@Juwang110 We don't have manufacturers service tests at all yet, and the pantries service tests are still mocking the repository. We don't need to worry about those tests here, we will add/update them in a future ticket! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes
📝 Description
added backend validation to throw a BadRequestException when a user tries to approve or deny a non pending pantry or manufacturer. also found a bug with foodManufacturer missing relations so fixed that too!
✔️ Verification
tried to approve/deny a non pending pantry/manufacturer