Edits to backend ticket guide up to sub-router#55
Open
Conversation
connernilsen
approved these changes
Apr 23, 2021
Member
connernilsen
left a comment
connernilsen
left a comment
There was a problem hiding this comment.
Looks good, but I saw there are still a few TODOs in there. Do we want to get this merged in and figure it out later, or fix them first?
| - __common/__ is a directory containing useful methods and classes for general use cases. This can include things | ||
| like authorization, passwords, logging, and properties files. | ||
| - __persist/__ is a directory for defining and handling the data used in our application. | ||
| - __service/__ holds the main method for the project, and it handles |
Member
There was a problem hiding this comment.
Extra space
Suggested change
| - __service/__ holds the main method for the project, and it handles | |
| - __service/__ holds the main method for the project, and it handles |
Comment on lines
+345
to
349
| if (this.title == null || this.title.length() == 0) { | ||
| invalidFields.add(fieldName + "title"); | ||
| } | ||
| if (this.body == null) { | ||
| if (this.body == null || this.body.length() == 0) { | ||
| invalidFields.add(fieldName + "body"); |
Member
There was a problem hiding this comment.
Should we change these to String.isEmpty() or do you think length is fine?
| when you're done. We'll later be registering this sub-router under a protected path, so we'll also be adding information | ||
| to it, like the `jwt_data` we get on the next line. The `JWTData` object contains secure information about the user, | ||
| such as their id, which we'll need for completing this ticket. | ||
| Route handlers methods take in |
Member
There was a problem hiding this comment.
Suggested change
| Route handlers methods take in | |
| Route handler methods take in |
| such as their id, which we'll need for completing this ticket. | ||
| Route handlers methods take in | ||
| a `RoutingContext`, defined by the Vert.x library, and don't return anything. The `RoutingContext` object gives | ||
| acess to request properties (like the body, path parameters, query parameters, ...), and allows you to respond to the request |
Member
There was a problem hiding this comment.
Suggested change
| acess to request properties (like the body, path parameters, query parameters, ...), and allows you to respond to the request | |
| access to request properties (like the body, path parameters, query parameters, ...), and allows you to respond to the request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left some todos in there