Change Password and Edit Personal Info For Settings Page#339
Merged
prooflesben merged 3 commits intomainfrom Mar 9, 2026
Merged
Change Password and Edit Personal Info For Settings Page#339prooflesben merged 3 commits intomainfrom
prooflesben merged 3 commits intomainfrom
Conversation
janekamata
reviewed
Feb 25, 2026
Contributor
janekamata
left a comment
janekamata
left a comment
There was a problem hiding this comment.
Have a few small fixes I think would be good to address
janekamata
reviewed
Feb 27, 2026
|
|
||
| {isEditingPersonalInfo ? ( | ||
| <div className="w-full max-w-3xl rounded-lg bg-gray-50 p-6 shadow-sm flex flex-col"> | ||
| <div className="w-full max-w-3xl rounded-lg bg-white p-6 shadow-sm flex flex-col"> |
Contributor
There was a problem hiding this comment.
Sorry, didn't notice this earlier, but It would be better to move the edit info part into the info card component itself. If you look at the design, the form takes the place of the static fields, so the size of the larger container doesn't change at all
prooflesben
requested changes
Mar 9, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
Editing the email there is no validation that it is a valid email it just approves anything.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #309
📝 Description
Implemented new designs for change password and edit personal information on the sign up page
Briefly list the changes made to the code:
✔️ Verification
Manual Testing on Frontend
🏕️ (Optional) Future Work / Notes
Needs connection to backend, right now using dummy info on frontend for edit personal information and does not do anything when save is clicked for changing password