Skip to content

Backport #78908 to 25.4: Support unix timestapms with fractional part in best effort DateTime64 parsing #82417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikitamikhaylov merged 1 commit into from
Jun 23, 2025
Merged

Backport #78908 to 25.4: Support unix timestapms with fractional part in best effort DateTime64 parsing #82417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/IO/parseDateTimeBestEffort.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ ReturnType parseDateTimeBestEffortImpl(

/// This is unix timestamp.
readDecimalNumber<10>(res, digits);
if (fractional && !in.eof() && *in.position() == '.')
{
++in.position();
fractional->digits = readDigits(digits, sizeof(digits), in);
readDecimalNumber(fractional->value, fractional->digits, digits);
}
return ReturnType(true);
}
if (num_digits == 9 && !year && !has_time)
Expand All @@ -194,6 +200,12 @@ ReturnType parseDateTimeBestEffortImpl(

/// This is unix timestamp.
readDecimalNumber<9>(res, digits);
if (fractional && !in.eof() && *in.position() == '.')
{
++in.position();
fractional->digits = readDigits(digits, sizeof(digits), in);
readDecimalNumber(fractional->value, fractional->digits, digits);
}
return ReturnType(true);
}
if (num_digits == 14 && !year && !has_time)
Expand Down
18 changes: 18 additions & 0 deletions ...ries/0_stateless/03407_parse_date_time_best_effort_unix_timestamp_with_fraction.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
2025-04-07 16:06:45.1
2025-04-07 16:06:45.12
2025-04-07 16:06:45.123
2025-04-07 16:06:45.1234
2025-04-07 16:06:45.12345
2025-04-07 16:06:45.123456
2025-04-07 16:06:45.1234567
2025-04-07 16:06:45.12345678
2025-04-07 16:06:45.123456789
1975-07-12 13:36:40.1
1975-07-12 13:36:40.12
1975-07-12 13:36:40.123
1975-07-12 13:36:40.1234
1975-07-12 13:36:40.12345
1975-07-12 13:36:40.123456
1975-07-12 13:36:40.1234567
1975-07-12 13:36:40.12345678
1975-07-12 13:36:40.123456789
22 changes: 22 additions & 0 deletions tests/queries/0_stateless/03407_parse_date_time_best_effort_unix_timestamp_with_fraction.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
set session_timezone='UTC';

select parseDateTime64BestEffort('1744042005.1', 1);
select parseDateTime64BestEffort('1744042005.12', 2);
select parseDateTime64BestEffort('1744042005.123', 3);
select parseDateTime64BestEffort('1744042005.1234', 4);
select parseDateTime64BestEffort('1744042005.12345', 5);
select parseDateTime64BestEffort('1744042005.123456', 6);
select parseDateTime64BestEffort('1744042005.1234567', 7);
select parseDateTime64BestEffort('1744042005.12345678', 8);
select parseDateTime64BestEffort('1744042005.123456789', 9);

select parseDateTime64BestEffort('174404200.1', 1);
select parseDateTime64BestEffort('174404200.12', 2);
select parseDateTime64BestEffort('174404200.123', 3);
select parseDateTime64BestEffort('174404200.1234', 4);
select parseDateTime64BestEffort('174404200.12345', 5);
select parseDateTime64BestEffort('174404200.123456', 6);
select parseDateTime64BestEffort('174404200.1234567', 7);
select parseDateTime64BestEffort('174404200.12345678', 8);
select parseDateTime64BestEffort('174404200.123456789', 9);

Loading