Merged
Conversation
CertainLach
force-pushed
the
feature/std-regex
branch
from
33ce087 to
8ec1af0
Compare
Owner
Author
|
Feature-gated as exp-regex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream issue: google/jsonnet#1039
Excluding questions asked upstream, it should be noted that rust regex crate and re2 syntax are not exactly the same because rust regexes have a bit more features regarding unicode character group matches.
However, there are not enough incompatibilities for writing a regex parser/transpiler closer to the RE2 syntax.