fix(openmemory): prevent multilingual simhash collisions across JS and Python#153
Open
zfaustk wants to merge 6 commits intoCaviraOSS:mainfrom
Open
fix(openmemory): prevent multilingual simhash collisions across JS and Python#153zfaustk wants to merge 6 commits intoCaviraOSS:mainfrom
zfaustk wants to merge 6 commits intoCaviraOSS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the multilingual simhash collision path behind
#147across both OpenMemory runtimes.Fixes #147.
Testing
cd packages/openmemory-py && pytest -q tests/test_multilingual_dedup.pycd packages/openmemory-js && timeout 20s npx --yes tsx tests/test_multilingual_dedup.tsNotes
test_multilingual_dedup.ts passed, but the process kept lingering handles alive afterward, so I wrapped that check withtimeout 20sfor this run.packages/openmemory-js/package-lock.jsonout of this patch because the only change was incidental install churn, not source behavior.