Open
Conversation
rm cached Update README.md
Contributor
|
@yuhi-n Thanks for this contribution and sorry for being slow to respond - all the COSP maintainers have "day jobs" i.e. other commitments. Before getting to the specific changes please revise pull request to make only the changes we want to include in the main COSP repository. That is, when the pull request is merged it should include the smallest number of changes to the code that will include the new functionality. Some specific suggestions:
Implementing these changes will make the pull request smaller and easier to review and approve. Please let me know if you have questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Yuhi Nakamura, AORI, the University of Tokyo. I am a member of Japanese EarthCARE project team.
Prof. Kenta Suzuki and I are developing new Doppler simulator to accommodate Doppler velocity observation by EarthCARE CPR.
Thank you for reviewing the previous version of Doppler signal simulator. We've resolved conflicts that occurred in the previous version.
To make contributions from this update clearer, I am resubmitting the pull request, and kindly ask for your code review.
This is an extension of the quickbeam routine to calculate Doppler velocity and spectrum width. Statistics is provided separately for stratiform and convective clouds because vertical air motion is differently obtained in a typical GCM.
The changed files are stored in
dplrw_src. I am providing test dataset generated by MIROC6 as a tarball at another repository (please see README), and python notebooks for visualization are attached indriver/check.Could you please review our codes and provide comments?
Thank you for your all effort on review processes.