Conversation
harryswift01
left a comment
There was a problem hiding this comment.
This looks like a great addition to correct the force halving for the flexible dihedrals. I can see this change has affected the regression results, and the regression baselines have been updated accordingly. The corresponding unit tests have also been updated. Happy to approve.
jimboid
left a comment
There was a problem hiding this comment.
Looks like a solid contribution to the code base! Removing duplicate counting of forces for multiple entropy types. This looks like a very complete PR with nice code inline with the accepted standards and norms on the repo, documented methods and the relevant tests in place. The baselines have been updated to reflect the greater accuracy of the code. Happy to approve this, thanks a lot Sarah!
Summary
This pull request adds force halving for degrees of freedom associated with flexible dihedrals. Flexible dihedrals are defined as dihedral angles which have more than one peak in their histogram of angle values. This eliminates double counting between the vibrational and conformational entropy terms.
Changes
Levels:
Entropy:
Unit Tests:
Regression Tests:
Impact