Enforce MAX_BULK_CACHED_SKELETONS limit at the API layer#11
Merged
fcollman merged 2 commits intobulk_skeleton_improvementsfrom Mar 18, 2026
Merged
Enforce MAX_BULK_CACHED_SKELETONS limit at the API layer#11fcollman merged 2 commits intobulk_skeleton_improvementsfrom
fcollman merged 2 commits intobulk_skeleton_improvementsfrom
Conversation
Co-authored-by: fcollman <782341+fcollman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback by enforcing server-side limit for bulk endpoints and auth token
Enforce MAX_BULK_CACHED_SKELETONS limit at the API layer
Mar 18, 2026
fcollman
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAX_BULK_CACHED_SKELETONSwas imported inapi.pybut only referenced in a docstring — the actual enforcement (silent truncation) happened deep in the service layer, invisible to callers.Changes
SkeletonResource__get_cached_skeletons_bulk.post()now checkslen(rids)againstMAX_BULK_CACHED_SKELETONSand returns400immediately if exceeded, rather than silently truncating in the service layer.Clients now get an explicit error instead of receiving a silently truncated result set.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.