Done some changes inside some function inside the core package + Others small changes#145
Done some changes inside some function inside the core package + Others small changes#145
Conversation
Cover NewRunner, Run, LoadConfig, UpdateFlags, StartFlagProcessingLoop, ValidateFlagTTL, and add test helpers for in-memory DB, submit stubs, and timing utilities
Replace Unicode section separators with ASCII dashes across tests.
Change DeleteFlagByTTL to compare response_time with
(CAST(strftime('%s', 'now') AS INTEGER) - ?) and regenerate query code
(param name updated).
Add module checksums to go.work.sum:
crawshaw.io/sqlite v0.3.2/go.mod
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1/go.mod
github.com/joho/godotenv v1.5.1/go.mod
akiidjk
requested review from
KronosPNG,
giovanni-iannaccone,
jose-sgariglia and
vympel7
akiidjk
added
documentation
|
@akiidjk there's no issue with the pull request description nor with internal files that make it easier to understand a specific module/subsystem. We're not following the test-driven approach we discussed, there's no test plan, no test case specification, we have discussed using category partitioning, since there's no case specification, there's no way category partitioning can be applied. We don't need a dependency graph for each submodule, although useful. We agreed to analyse the system as a whole beforehand, document the state of the project, plan future operations, then proceed with reengineering, nothing like that has been done. I cannot give a lot of comments on the code itself, but everything else is not on par with the goals we set up together. |
|
I will work on the missing part indicated. For fill the gaps |
|
And although I understand the need to change a large amount of files, adding new ones to make the previous work, but consider making smaller pull requests or requesting review per commit instead of leaving 2k loc to analyse to the others |
|
Most of the code concerns updating dependencies or formatting issue, so it can be skipped. But I will follow the advice |
2 participants
This pull requests aim to improve some aspect of the readability and maintenance of the code inside the server/core package and in the addition of all tests for this function read ANALYSIS.md inside the PR for more information about the tests and the structure of the package.
Others minor changes are done inside the PR.
go mod tidyfor sync)@KronosPNG this PR is not complete write me witch part of the documentation miss inside the ANALYSIS.md file. I have not do big or complex edit to the flow, or the logic of the core package.
Warning
Copilot summary down
Dependency updates and additions:
cookiefarm/client/config/go.mod, includinggithub.com/kr/prettyandgopkg.in/check.v1, and addedgithub.com/rogpeppe/go-internal.github.com/stretchr/testify v1.11.1as an indirect dependency to multiplego.modfiles (cookiefarm/client/api/go.mod,cookiefarm/client/go.mod,cookiefarm/client/websockets/go.mod,cookiefarm/pkg/logger/go.mod,cookiefarm/server/api/go.mod). [1] [2] [3] [4] [5]cookiefarm/client/exploit/go.mod, addinggithub.com/ByteTheCookies/CookieFarm, several Charmbracelet packages, and others for enhanced functionality.cookiefarm/go.work.sumto reflect new and changed dependencies, including new versions and removals for several packages. [1] [2] [3]Code and UI improvements:
cookiefarm/client/tui/view.goby changing the process selection list separator from"─"to"-"for better compatibility.cookiefarm/pkg/protocols/cc_http.goto follow Go conventions.cookiefarm/server/cmd/root.goto separate config loading and running, improving clarity and error handling.