Skip to content

Adding automation groups#747

Open
gtfierro wants to merge 20 commits intomasterfrom
fix-issue-722
Open

Adding automation groups#747
gtfierro wants to merge 20 commits intomasterfrom
fix-issue-722

Conversation

@gtfierro
Copy link
Member

Addressing #722

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

Co-authored-by: Dogan Fennibay <Dogan.Fennibay.Tr+github@ieee.org>
@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@fennibay
Copy link
Contributor

This is the current validation error:

   Severity: sh:Violation
  Focus Node: <urn:example/collection#Ahu>
  Message: Value must have at least one of the following shapes: _:7ed7414772658c5d3453cd82915382c7, _:e07496e981cc2a35110fc89f8f65c0eb
  Path: brick:hasPart
  Value: <urn:example/collection#FrostDetection>
  Source Constraint: sh:OrConstraintComponent
  Source Shape: _:ne1f5e65888c64b61a1d5168bc478d3ddb3

My interpretation is that we're now running against the following constraint

sh:property [
sh:path brick:hasPart;
sh:or (
[ sh:class brick:Equipment ]
[ sh:class brick:Automation_Group ]
) ;

But urn:example/collection#FrostDetection is of type brick:AutomationGroup. So I don't understand what is going wrong here.

Could it be that the SHACL engine is using a cached version or a different format of this ttl file?

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@gtfierro
Copy link
Member Author

gtfierro commented Jan 1, 2026

Could it be that the SHACL engine is using a cached version or a different format of this ttl file?

It was actually a different constraint that was getting triggered! I had to add a feature to my SHACL engine to follow blank nodes in the report which let me see what the rest of the shape was.

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@gtfierro gtfierro self-assigned this Mar 19, 2026
@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

@github-actions
Copy link

The latest build of the Brick ontology on this PR is available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants