Publish gl-sdk on npm registry#667
Conversation
776e693 to
07e9060
Compare
07e9060 to
5676074
Compare
|
The first two commits are a continuation of PR Add TypeScript support via N-API. In the initial implementation, I overlooked adding a |
|
Hi @cdecker, The PR is ready for review but before the library can be published to npm, a few items need clarification: 1. npm Organization Access & Package Conventions 2. NPM_TOKEN Repository Secret To unblock testing against 3. Workflow Trigger 4. Platform Support
Happy to make any adjustments. Please let me know how you'd like to proceed. |
cdecker
left a comment
There was a problem hiding this comment.
Looks like once again I forgot to submit my reviews 🤦
Thanks @ShahanaFarooqui for sharing the information, I think the @blockstream org on npmjs.org is completely unrelated to us, and so creating a new org is likely not the worst idea (any chance we can claim the global glsdk package name?). I'll see what I can do re policy for npm packages.
In the meantime I have also added the secret, so we should now be able to test the full roundtrip 👍
|
Very nice overall, I am eager to merge this :-) |
5676074 to
92bae91
Compare
Turns out |
92bae91 to
776e693
Compare
0dd6e09 to
f099837
Compare
|
Closing this PR in favour of #671, as CI is passing and the library is successfully being published to npm via GitHub Actions in that PR. Published @greenlightcln/glsdk@0.0.1 with workflow 22158240201 |
No description provided.