Fix read-only mode with separate WAL object store#359
Merged
Conversation
Let DbReader manage its own checkpoint via manifest polling instead of manually creating detached checkpoints and swapping readers. This removes the checkpoint refresh task entirely and uses the new DbReaderBuilder::with_wal_object_store() to pass the WAL store to readers in all modes (read-only, checkpoint).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let DbReader manage its own checkpoint via manifest polling instead of manually creating detached checkpoints and swapping readers. This removes the checkpoint refresh task entirely and uses the new DbReaderBuilder::with_wal_object_store() to pass the WAL store to readers in all modes (read-only, checkpoint).