Skip to content

fix: add CLAUDE.md to vendor excludes#236

Merged
DASPRiD merged 1 commit intoBacon:mainfrom
williamdes:patch-1
Apr 5, 2026
Merged

fix: add CLAUDE.md to vendor excludes#236
DASPRiD merged 1 commit intoBacon:mainfrom
williamdes:patch-1

Conversation

@williamdes
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (11485d8) to head (356b3b9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #236   +/-   ##
=========================================
  Coverage     71.72%   71.72%           
  Complexity      999      999           
=========================================
  Files            49       49           
  Lines          3158     3158           
=========================================
  Hits           2265     2265           
  Misses          893      893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DASPRiD DASPRiD changed the title Add CLAUDE.md to vendor excludes fix: add CLAUDE.md to vendor excludes Apr 5, 2026
@DASPRiD DASPRiD merged commit cde3eae into Bacon:main Apr 5, 2026
8 of 9 checks passed
@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Apr 5, 2026

Thanks! I really wish we'd have a whitelist instead of a blacklist way, just like package.json has… :)

@williamdes williamdes deleted the patch-1 branch April 5, 2026 21:52
@williamdes
Copy link
Copy Markdown
Contributor Author

Thanks! I really wish we'd have a whitelist instead of a blacklist way, just like package.json has… :)

.gitignore has this by using

/
!/keepme

maybe gitattributes has it too
But you would have to do a self-test to ensure it is up to date.
ask for a git archive, keep tests from the checkout
manage to build an autoloader for both
and run tests

Welcome to what we have to do in Debian:

@williamdes
Copy link
Copy Markdown
Contributor Author

By the way at phpMyAdmin I built a script to find such dev files and add them to an exclude list: https://github.com/phpmyadmin/phpmyadmin/blob/QA_5_2/scripts/check-release-excludes.sh

@DASPRiD
Copy link
Copy Markdown
Member

DASPRiD commented Apr 6, 2026

@williamdes Hm, I suppose I could introduce a simple github workflow step which validates that a git archvie tar only includes composer.json, LICENSE, README.md and the src folder.

I suppose that should be safe?

@williamdes
Copy link
Copy Markdown
Contributor Author

@williamdes Hm, I suppose I could introduce a simple github workflow step which validates that a git archvie tar only includes composer.json, LICENSE, README.md and the src folder.

I suppose that should be safe?

Absolutely
My script allows to do that in some ways
But see how I auto test Doctum: https://github.com/code-lts/doctum/blob/main/tests/composer-package-auto-test.sh

It is really important to run tests against the archive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants