feat!: replace dasprid/enum with native PHP enums#230
Open
Conversation
BREAKING CHANGE: All enum classes (ErrorCorrectionLevel, Mode, CharacterSetEci, GradientType) are now native PHP enums. Static method access like ErrorCorrectionLevel::L() must be changed to ErrorCorrectionLevel::L (without parentheses). Closes #198 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
============================================
+ Coverage 71.81% 72.72% +0.90%
- Complexity 995 1075 +80
============================================
Files 49 49
Lines 3151 3226 +75
============================================
+ Hits 2263 2346 +83
+ Misses 888 880 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
You may also want to update in CLAUDE.md, changing: - `Version`, `ErrorCorrectionLevel`, `Mode`, `CharacterSetEci` - QR spec enums (using `dasprid/enum`)to: - `Version`, `ErrorCorrectionLevel`, `Mode`, `CharacterSetEci` - QR spec enums |
Member
Author
|
@vlakoff good point. the rest of the implementation looks fine to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All enum classes (ErrorCorrectionLevel, Mode, CharacterSetEci, GradientType) are now native PHP enums. Static method access like ErrorCorrectionLevel::L() must be changed to ErrorCorrectionLevel::L (without parentheses).
Closes #198