Markdown to HTML in gulp script#639
Draft
CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
Draft
Markdown to HTML in gulp script#639CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
CedricGuillemet wants to merge 2 commits intoBabylonJS:masterfrom
Conversation
ryantrem
reviewed
Feb 13, 2024
| let basekitPackagePath = ''; | ||
|
|
||
|
|
||
| const makeHTMLNotice = async () => { |
Member
There was a problem hiding this comment.
This function is marked async but then uses fs with callbacks. I believe these days you can do const fs = require('fs/promises') instead and use Promise returning async functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gulp script that converts a .MD file to Notice.html that can then be packaged with the npm.
As a test, this script converts the readme file.
Result:
TODO: