Skip to content

Fix invalid CMake command in Linux building instructions #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 2 commits into from
Mar 10, 2026
Merged

Fix invalid CMake command in Linux building instructions #1625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0f94eb
Initial plan
Copilot Mar 10, 2026
42f0109
Fix invalid CMake command with stray -D in Linux building instructions
Copilot Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ sudo apt-get install libjavascriptcoregtk-4.1-dev
Then, run cmake targetting a Ninja make file:

```
cmake -G Ninja -D -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore
cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore
```

### V8
Expand All @@ -309,13 +309,13 @@ sudo apt-get install libv8-dev
Then, run cmake targetting a Ninja make file:

```
cmake -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8
cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=V8
```

And finally, for any JavaScript engine, run a build:

```
ninja
cmake --build build/linux
```

You can switch compiler between GCC and Clang by defining shell variables.
Expand Down