Skip to content

Adding quickstart for validate with a Linux image#36

Open
kof-f wants to merge 1 commit intomainfrom
validator_with_linux_quickstart
Open

Adding quickstart for validate with a Linux image#36
kof-f wants to merge 1 commit intomainfrom
validator_with_linux_quickstart

Conversation

@kof-f
Copy link
Contributor

@kof-f kof-f commented May 25, 2022

No description provided.

"customize": [
{
"type": "Shell",
"name": "AddBuildArtifacts3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: What is the significance of 3 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation.
Please check everywhere in this file.

@@ -0,0 +1,57 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the filename consistent with existing naming scheme.
If current scheme doesn't seem okay to you then please change the scheme for all of them - but the customer should have a consistent experience.

@@ -0,0 +1,57 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share details on how this has been tested?
For example, a customer would likely copy-paste this text; look for everything in angle brackets "<>" and replace with custom values. At that point the template should just work.
Has such a run been done on this quickstart example?

"sudo touch /buildArtifacts3/imageBuilder.md"
]
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants