Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14709#45922

Merged
benbp merged 4 commits intomainfrom
sync-eng/common-benbp/azsdk-install-perf-14709
Mar 25, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14709#45922
benbp merged 4 commits intomainfrom
sync-eng/common-benbp/azsdk-install-perf-14709

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14709 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 25, 2026 21:46
@azure-sdk azure-sdk requested review from benbp and Copilot March 25, 2026 21:46
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs the eng/common MCP installer script with upstream azure-sdk-tools changes related to azure-sdk-tools PR 14709, focusing on how the azsdk CLI MCP server is installed and launched.

Changes:

  • Hard-codes the azsdk CLI package identifiers in the installer script (removing -FileName / -Package parameters).
  • Adds an “already installed + up-to-date” fast-path using azsdk upgrade --check --output json.
  • Updates the run invocation to use the mcp subcommand and propagates the child process exit code.
Comments suppressed due to low confidence (1)

eng/common/mcp/azure-sdk-mcp.ps1:156

  • In the non--Run path, the Install-Standalone-Tool call ends with a line-continuation backtick after -Repository $Repository, but there’s no subsequent continuation content. This leaves the script syntactically invalid (it will fail to parse before executing). Remove the trailing backtick (or add the missing continuation) so the installer path can run.
        -Package $packageName `
        -Directory $tempInstallDirectory `
        -Repository $Repository `

}

@benbp benbp merged commit 2f38c43 into main Mar 25, 2026
25 checks passed
@benbp benbp deleted the sync-eng/common-benbp/azsdk-install-perf-14709 branch March 25, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants