[AutoPR azure-security-keyvault-certificates]-generated-from-SDK Generation - Java-5984840#48418
Open
rohitsinghal4u wants to merge 15 commits intomainfrom
Open
[AutoPR azure-security-keyvault-certificates]-generated-from-SDK Generation - Java-5984840#48418rohitsinghal4u wants to merge 15 commits intomainfrom
rohitsinghal4u wants to merge 15 commits intomainfrom
Conversation
…s/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '35275d315efee7fa79b6661c29cb3f1c05e86b76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5984840 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…rtificates-5984840' into pr-48346-check
…ed dep failures When generate_from_source_pom.py walks up the parent POM chain in add_source_projects, it was adding all parent POMs to the from-source reactor including stable ones (dep_version == current_version) such as azure-cosmos-spark_3 and azure-cosmos-spark_3-5. Stable parent POMs are already published to the artifact feed. When Maven includes them as reactor modules (packaging=pom), it validates their declared test-scope dependencies. azure-cosmos-spark_3 has a direct test-scope dependency on azure-cosmos-test:1.0.0-beta.18 (unreleased), causing keyvault from-source builds to fail with: 'Could not find artifact com.azure:azure-cosmos-test:jar:1.0.0-beta.18' Maven does not need these parent POMs in the reactor -- it resolves them via relativePath from the local filesystem for configuration inheritance. Only parent POMs that are not yet released (dep != current) OR are in parent_pom_identifiers need to be in the from-source reactor. This fixes the ubuntu2404_125_FromSource_SkipRebuild_Verify CI failure introduced by the spark 4.45.0 release (#48413) which bumped azure-cosmos-test to current version 1.0.0-beta.18 (unreleased).
The previous fix removed stable parent POMs (azure-cosmos-spark_3, azure-cosmos-spark_3-5) from the from-source reactor. However, modules that remain in the reactor (azure-cosmos-spark_3-5_2-12) still inherit test dependencies from those stable parent POMs via the relativePath parent chain. Specifically: azure-cosmos-spark_3-5_2-12 -> azure-cosmos-spark_3-5 -> azure-cosmos-spark_3 azure-cosmos-spark_3 declares azure-cosmos-test:1.0.0-beta.18 (unreleased) azure-cosmos-spark_3-5_2-12 inherits this as a test-scope dependency Without azure-cosmos-test in the reactor, Maven fails trying to download the unreleased artifact from the feed. Fix resolve_project_dependencies to walk the FULL parent POM chain (not just one level deep) when collecting dependencies. This ensures that azure-cosmos-test:1.0.0-beta.18 is discovered as an inherited dependency of azure-cosmos-spark_3-5_2-12 and added to the from-source reactor, where it can be built from source instead of downloaded from the feed.
rohitsinghal4u
requested review from
a team,
benbp,
raych1 and
weshaggard
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure Key Vault Certificates SDK generation inputs and generated code to align with the 2025-07-01 service API, including new model surface and service version constants, plus a build tooling improvement for from-source Maven reactors.
Changes:
- Added support for new
SubjectAlternativeNamesfields (uris,ipAddresses) and surfaced them in JSON serialization. - Added new
CertificateServiceVersionenum values for2025-06-01-previewand2025-07-01. - Improved
generate_from_source_pom.pyto walk the full parent POM chain for dependency resolution and to avoid adding already-released parent POMs to the reactor when unnecessary.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/keyvault/azure-security-keyvault-certificates/tsp-location.yaml | Updates spec repo commit SHA for generation provenance. |
| sdk/keyvault/azure-security-keyvault-certificates/src/main/java/com/azure/security/keyvault/certificates/models/SubjectAlternativeNames.java | Adds new SAN properties and JSON read/write support. |
| sdk/keyvault/azure-security-keyvault-certificates/src/main/java/com/azure/security/keyvault/certificates/implementation/CertificateClientImpl.java | Updates purge deleted certificate request handling and schema docs to include new SAN fields. |
| sdk/keyvault/azure-security-keyvault-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateServiceVersion.java | Adds new service API version constants. |
| sdk/keyvault/azure-security-keyvault-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateClient.java | Adjusts purge deleted certificate call to ensure Accept: application/json is set. |
| sdk/keyvault/azure-security-keyvault-certificates/src/main/java/com/azure/security/keyvault/certificates/CertificateAsyncClient.java | Adjusts purge deleted certificate call to ensure Accept: application/json is set. |
| sdk/keyvault/azure-security-keyvault-certificates/customizations/src/main/java/CertificatesCustomizations.java | Extends generated enum customization to include new service versions. |
| sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md | Records generated API surface changes and bug fix entry. |
| eng/scripts/generate_from_source_pom.py | Enhances dependency resolution and reactor composition logic for from-source builds. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+3
to
+8
| ## 4.9.0-beta.1 (2026-03-10) | ||
|
|
||
| ### Features Added | ||
|
|
||
| ### Breaking Changes | ||
| #### `models.SubjectAlternativeNames` was modified | ||
|
|
…NGELOG Per Azure SDK conventions, the top CHANGELOG entry should use (Unreleased) until a release is cut. Also restores the Breaking Changes and Other Changes section headers that were missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/keyvault/Security.KeyVault.Certificates/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: '35275d315efee7fa79b6661c29cb3f1c05e86b76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5984840 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.