Allow multiple filesystems for a single storage account by ghostofthecode · Pull Request #48414 · Azure/azure-sdk-for-java

ghostofthecode · 2026-03-13T17:53:41Z

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

github-actions · 2026-03-13T17:54:06Z

Thank you for your contribution @ghostofthecode! We will review the pull request and get back to you soon.

Copilot

Pull request overview

This PR updates the azure-storage-blob-nio NIO FileSystemProvider URI handling to allow creating multiple FileSystem instances for the same storage account endpoint by introducing an additional uid query parameter.

Changes:

Extend the filesystem URI format with an optional uid query parameter and update tests to cover distinct UIDs.
Update AzureFileSystemProvider to parse uid and use it to distinguish cached/open file systems.
Add an (unreleased) changelog entry describing the new URI format.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File	Description
sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java	Parses `uid` from the URI and changes the open-filesystem cache keying strategy.
sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/BlobNioTestBase.java	Adds a `getFileSystemUri(String uid)` helper to generate URIs with a `uid`.
sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTests.java	Adds tests for creating distinct filesystems via different UIDs and updates duplicate-creation coverage.
sdk/storage/azure-storage-blob-nio/CHANGELOG.md	Documents the new filesystem URI shape in the Unreleased section.

Comments suppressed due to low confidence (1)

sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java:240

newFileSystem() and getFileSystem() Javadoc still states the URI format is azb://?endpoint=<endpoint>, but this PR introduces uid to distinguish multiple filesystems. Update these docs to reflect the supported format (including whether uid is optional and what the default behavior is when it’s omitted).

    /**
     * Constructs a new FileSystem object identified by a URI.
     * <p>
     * The format of a {@code URI} identifying a file system is {@code "azb://?endpoint=<endpoint>"}.
     * <p>
     * Once closed, a file system with the same identifier may be reopened.
     *
     * @param uri URI reference
     * @param config A map of provider specific properties to configure the file system
     * @return a new file system.
     * @throws IllegalArgumentException If the pre-conditions for the uri parameter aren't met, or the env parameter
     * does not contain properties required by the provider, or a property value is invalid.
     * @throws IOException If an I/O error occurs.
     * @throws SecurityException never
     * @throws FileSystemAlreadyExistsException If the file system has already been created.
     */
    @Override
    public FileSystem newFileSystem(URI uri, Map<String, ?> config) throws IOException {
        FileSystemUriParameters parameters = parseFileSystemParameters(uri);

        if (this.openFileSystems.containsKey(parameters.uid())) {
            throw LoggingUtility.logError(ClientLoggerHolder.LOGGER,
                new FileSystemAlreadyExistsException("Name: " + parameters.endpoint() + " UID: " + parameters.uid()));
        }

        AzureFileSystem afs = new AzureFileSystem(this, parameters.endpoint(), config);
        this.openFileSystems.put(parameters.uid(), afs);

        return afs;
    }

    /**
     * Returns an existing FileSystem created by this provider.
     * <p>
     * The format of a {@code URI} identifying a file system is {@code "azb://?endpoint=&lt;endpoint&gt;"}.
     * <p>
     * Trying to retrieve a closed file system will throw a {@link FileSystemNotFoundException}. Once closed, a
     * file system with the same identifier may be reopened.
     *

You can also share your feedback on Copilot code review. Take the survey.

...azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java

+        String endpoint = "", uid = "";
+        for (String queryPart : uri.getQuery().split("&")) {
+            String[] parts = queryPart.split("=");
+            switch (parts[0]) {
+                case ENDPOINT_QUERY_KEY:
+                    endpoint = parts.length > 1 ? parts[1] : "";
+                    break;
+
+                case UID_QUERY_KEY:
+                    uid = parts.length > 1 ? parts[1] : "";
+                    break;
+            }
+        }
+        uid = CoreUtils.isNullOrEmpty(uid) ? endpoint : uid;

+        String expectedFormat
+            = "FileSystems require a URI of the format \"azb://?endpoint=<endpoint>&uid=<unique_id>\"";
+        if (CoreUtils.isNullOrEmpty(uid)) {
+            throw LoggingUtility.logError(ClientLoggerHolder.LOGGER, new IllegalArgumentException(
+                "URI does not contain an \"" + UID_QUERY_KEY + "=\" parameter. " + expectedFormat));
+        }
        if (CoreUtils.isNullOrEmpty(endpoint)) {
            throw LoggingUtility.logError(ClientLoggerHolder.LOGGER,
-                new IllegalArgumentException("No account endpoint provided in URI query."));
+                new IllegalArgumentException("No account endpoint provided in URI query. " + expectedFormat));


...azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java

+        for (String queryPart : uri.getQuery().split("&")) {
+            String[] parts = queryPart.split("=");
+            switch (parts[0]) {
+                case ENDPOINT_QUERY_KEY:
+                    endpoint = parts.length > 1 ? parts[1] : "";
+                    break;
+
+                case UID_QUERY_KEY:
+                    uid = parts.length > 1 ? parts[1] : "";
+                    break;


sdk/storage/azure-storage-blob-nio/CHANGELOG.md

 ## 12.0.0-beta.37 (Unreleased)
+- Extend azure nio filesystem url to support a unique identifer: `azb://?endpoint=<account_endpoint>&uid=<unique_id>`


...azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java

    public FileSystem newFileSystem(URI uri, Map<String, ?> config) throws IOException {
-        String endpoint = extractAccountEndpoint(uri);
+        FileSystemUriParameters parameters = parseFileSystemParameters(uri);

-        if (this.openFileSystems.containsKey(endpoint)) {
+        if (this.openFileSystems.containsKey(parameters.uid())) {
            throw LoggingUtility.logError(ClientLoggerHolder.LOGGER,
-                new FileSystemAlreadyExistsException("Name: " + endpoint));
+                new FileSystemAlreadyExistsException("Name: " + parameters.endpoint() + " UID: " + parameters.uid()));
        }

-        AzureFileSystem afs = new AzureFileSystem(this, endpoint, config);
-        this.openFileSystems.put(endpoint, afs);
+        AzureFileSystem afs = new AzureFileSystem(this, parameters.endpoint(), config);
+        this.openFileSystems.put(parameters.uid(), afs);


...-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTests.java

+    @ParameterizedTest
+    @ValueSource(strings = { "", "test-uid" })
+    public void createFileSystemDuplicate(String uid) throws IOException {
+        URI uri = getFileSystemUri(uid == "" ? null : uid);


sdk/storage/azure-storage-blob-nio/CHANGELOG.md

 # Release History

 ## 12.0.0-beta.37 (Unreleased)
+- Extend azure nio filesystem url to support a unique identifer: `azb://?endpoint=<account_endpoint>&uid=<unique_id>`


sdk/storage/azure-storage-blob-nio/CHANGELOG.md

...azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java

    void closeFileSystem(String fileSystemName) {
        this.openFileSystems.remove(fileSystemName);
    }

-    private String extractAccountEndpoint(URI uri) {
+    /**


ghostofthecode · 2026-03-13T17:59:52Z

@alzimmermsft, @browndav-msft, @browndav-msft, @gunjansingh-msft, @ibrandes, @kyleknap

the proposed test changes involve amendments to test-proxy assets which I am not able to modify, could you suggest how they could be updated?

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Allow multiple filesystems for a single storage account

3a55440

ghostofthecode requested review from alzimmermsft and browndav-msft as code owners March 13, 2026 17:53

Copilot AI review requested due to automatic review settings March 13, 2026 17:53

ghostofthecode requested review from a team, gunjansingh-msft, ibrandes, kyleknap and seanmcc-msft as code owners March 13, 2026 17:53

github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Mar 13, 2026

Copilot started reviewing on behalf of ghostofthecode March 13, 2026 17:54 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

ghostofthecode and others added 2 commits March 13, 2026 20:36

fix file system close with a custom uid

c575ddf

Potential fix for pull request finding

9abee0a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow multiple filesystems for a single storage account#48414

Allow multiple filesystems for a single storage account#48414
ghostofthecode wants to merge 3 commits intoAzure:mainfrom
ghostofthecode:multiple-filesystems

ghostofthecode commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

ghostofthecode commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		## 12.0.0-beta.37 (Unreleased)
		- Extend azure nio filesystem url to support a unique identifer: `azb://?endpoint=<account_endpoint>&uid=<unique_id>`

Conversation

ghostofthecode commented Mar 13, 2026

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

ghostofthecode commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants