Merged
Conversation
Errors fixed: - CS0103: Replace removed SendResultAsync with IResult.ExecuteAsync(HttpContext) - Update ComponentHtmlResponseService to call static HtmlBeautifier.BeautifyHtml Warnings fixed: - IDE0073: Update .editorconfig file_header_template from TaLibStandard to FastComponents and add correct copyright headers to all 13 source files - CA1716: Suppress for HtmxComponentBase.As (renaming would be a breaking change) - CA1822: Make HtmlBeautifier.BeautifyHtml static - CA2263: Use generic Activator.CreateInstance<T>() overload - IDE0058: Add discards for unused expression values - IDE0340: Use unbound generic type in nameof expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendResultAsyncwithIResult.ExecuteAsync(HttpContext)(FastEndpoints v8 API change).editorconfig: correctfile_header_templatefrom TaLibStandard to FastComponentsErrors Fixed
SendResultAsyncdoes not existresponse.ExecuteAsync(HttpContext)Warnings Fixed
.editorconfigheader + add headers to all filesAsproperty (breaking change to rename)HtmlBeautifier.BeautifyHtmlstaticActivator.CreateInstance<T>()generic overload_ =) for unused expressionsnameofResolves failing run #22526226772
Test plan