Open
Conversation
|
Resolves #56 |
subins2000
suggested changes
Dec 30, 2023
subins2000
left a comment
subins2000
left a comment
There was a problem hiding this comment.
@HelllGuest I would also recommend to remove the copy button logic from this file since now the footer has the JS code https://github.com/AsahiLinux/AsahiLinux.github.io/blob/f2f936dbfe37476a4ae39f4afc51ae3a57c488c7/content/fedora.md
Resolved issue with non-functional clipboard button on homepage. Signed-off-by: Anoop Kumar <anoopkumar1119@gmail.com>
Author
@subins2000 Done. |
marcan
force-pushed
the
main
branch
3 times, most recently
from
6fdf253 to
23a8902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team,
Resolved issue with non-functional clipboard button on homepage.
What I did:
- Made some code changes to get it working smoothly- Tested it to make sure it's all good- Please take a look and let me know if you find any issues- Added the following to the layouts\partials\footer.html~~ ~~<!-- JavaScript code -->~~ ~~<script>~~ ~~document.getElementById('copy-button').addEventListener('click', () => {~~ ~~const curl = document.getElementById('curl');~~ ~~const range = document.createRange();~~ ~~range.selectNodeContents(curl);~~ ~~window.getSelection().removeAllRanges();~~ ~~window.getSelection().addRange(range);~~ ~~document.execCommand('copy');~~ ~~});~~ ~~</script>~~ ~~Thanks!