Skip to content

Better disconnection handling #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SuperCuber wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Better disconnection handling #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ketu/async/source.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
(ns ketu.async.source
(:require [clojure.core.async :as async]
[clojure.core.async.impl.protocols :as async-protocols]
[ketu.async.util :as util]
[ketu.clients.consumer :as consumer]
[ketu.shape.consumer :as shape]
Expand Down Expand Up @@ -125,7 +126,10 @@

(loop []
(when-let [records (poll!)]
(run! put! records)
(if (seq records)
Copy link
Author

@SuperCuber SuperCuber Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means an additional listTopics network call every time an empty poll is received. Might have performance/load implications? I doubt it, since it only happens when 0 lag and the call should be pretty lightweight.

(run! put! records)
; Throws exception if not connected
Copy link
Author

@SuperCuber SuperCuber Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want automatic recovery? or does it belong in the application / wrapper library?

(.listTopics consumer (Duration/ofMillis 5000)))
Copy link
Author

@SuperCuber SuperCuber Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more timeout field to the config perhaps?

(recur)))

(catch WakeupException e
Expand Down Expand Up @@ -211,6 +215,9 @@
(defn done-chan [state]
(:ketu.source/consumer-thread state))

(defn closed? [consumer]
(-> consumer :ketu.source/out-chan async-protocols/closed?))
Copy link
Author

@SuperCuber SuperCuber Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also use done-chan


(defn- wait-for-the-thread! [state]
(let [consumer-thread (:ketu.source/consumer-thread state)
consumer-thread-timeout-ms (-> state :ketu/source-opts :ketu.source/consumer-thread-timeout-ms)
Expand Down
Loading