fix: align wallet E2E tests to current UI structure#347
Merged
Conversation
- table_net_gross: scope to first .wallet-table to avoid matching the new expired attribution table (7+5=12 headers) - manual payment: reset count in beforeEach to avoid cross-test accumulation
|
Currents Tests: Tryber.me tests passed after 3m 16.1s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sommario
Fix di due test E2E del wallet che stavano fallendo in CI a causa di modifiche recenti all'UI.
1.
table_net_gross.spec.ts— selettore ambiguoÈ stata aggiunta di recente una seconda tabella nella pagina wallet (expired attribution table, 5 colonne). Il selettore
.wallet-tabletrovava entrambe le tabelle, restituendo 12 header invece dei 7 attesi.Fix: aggiunto
.first()su tutti i test del file per scoped alla tabella dei pagamenti.2.
payment_requests/manual.spec.ts— counter non resettatoLa variabile
count(che traccia le GET a/users/me/paymentsdopo il POST) era dichiarata a livellodescribema non resettata nelbeforeEach, causando accumulo tra i test dello stesso describe block (0→2→4 invece di 0→2 per ogni test).Fix: aggiunto
count = 0all'inizio delbeforeEachinterno.Test plan
table_net_gross.spec.ts: tutti e 4 i test passanopayment_requests/manual.spec.ts: tutti e 92 i test passano