fix: data-viz skill not invoked by LLM — reduce description size, improve intent matching#444
fix: data-viz skill not invoked by LLM — reduce description size, improve intent matching#444arora-saurabh448 wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThese changes shorten and rephrase the data-viz skill frontmatter to use intent-driven trigger examples and update the system prompt to instruct the agent to check skill applicability and load matching skills via the skill tool before starting work. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Agent as Agent
participant SkillChecker as Skill Checker
participant SkillTool as Skill Tool
participant SkillRepo as Skill Repository
User->>Agent: Request (e.g., "show trends for Q1")
Agent->>SkillChecker: Evaluate intent vs. skills
SkillChecker->>SkillRepo: Query matching skills
SkillRepo-->>SkillChecker: Return matching skill(s)
SkillChecker->>Agent: Recommend loading skill
Agent->>SkillTool: Load selected skill
SkillTool-->>Agent: Skill loaded (context & references)
Agent->>User: Proceed with skill-aware response
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
>folded scalar — reduced to 382 chars, fixed formatting, added intent-based trigger examples ("show me trends", "break down costs by region")Root Cause
Traced via
/traceacross 33+ sessions: thedata-vizskill was loaded correctly at the system level but the LLM never called theskilltool to load its instructions — even across 7 visualization-related sessions (dashboards, charts, chart fixes). Three factors combined:>block)\n</description>XML tagTest plan
altimate skill test data-vizpassesaltimate skill list --jsonshows no trailing newline, description under 400 charsaltimate run --yolo --max-turns 3 "visualize sales trends"invokes the skill toolaltimate run --yolo --max-turns 3 "show me costs by region"invokes the skill tool (intent match, no keyword)Summary by CodeRabbit