update spatial_detection_scores to use bin_size instead of n_bins for…#29
Open
shachafl wants to merge 2 commits intoAllenInstitute:mainfrom
Open
update spatial_detection_scores to use bin_size instead of n_bins for…#29shachafl wants to merge 2 commits intoAllenInstitute:mainfrom
shachafl wants to merge 2 commits intoAllenInstitute:mainfrom
Conversation
… spatial grouping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't replace n_bins with bin_size in the notebooks (spatial_compare_examples.ipynb, dataset_testing.ipynb) so this will cause an error.
I think it is better to clear all the outputs in the jupyter notebooks prior to uploading to repository or else there are a lot of "non code" for git to follow. This could also be addressed in a different PR.