Open
Conversation
d604981 to
ddc20d1
Compare
hanwen-sun
reviewed
Feb 12, 2025
|
|
||
| declare -A BACKAND_PARAMS=( | ||
| ["torchacc"]="--backend lazy" | ||
| ["hybridtrace"]="--backend lazy --hybrid_trace" |
There was a problem hiding this comment.
It's a little strange to specify both eager/lazy backend and partial_compile/hybrid_trace in the command. Can we hide the backend option in the command(reserve in the Backendconfig)?
for example, --lazy represents LTC trace and lazy mode, --eager represents eager mode and cuda native, --hybridtrace represents lazy mode but hybridtrace, --partial_compile represents eager mode but dynamo + xla.
We only need to check if xla is aviliable in the environment for lazy mode.
What's more, we need add comments or docs for these options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.