fix: build from checked-out source, not stale desktop copy#10
Merged
Akshat-Raj merged 1 commit intomainfrom Mar 7, 2026
Merged
fix: build from checked-out source, not stale desktop copy#10Akshat-Raj merged 1 commit intomainfrom
Akshat-Raj merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the ShieldCI GitHub Actions workflow to build and run from the checked-out source in $GITHUB_WORKSPACE instead of a stale copy assumed to exist at $HOME/Desktop/ShieldCI. It also moves hardcoded API credentials to GitHub Actions secrets and adds new steps for building the Kali Docker image and installing test dependencies.
Changes:
- Replaced all
$HOME/Desktop/ShieldCIpath references with$GITHUB_WORKSPACE, ensuring the workflow operates on the checked-out repository source. - Moved
SHIELDCI_API_URLandSHIELDCI_API_KEYfrom hardcoded values to${{ secrets.* }}references, eliminating credential exposure. - Replaced the old "Copy shieldci.yml config" and "Copy target repo to engine" steps with "Build Kali Docker image" and "Install test app dependencies" steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.