Skip to content

fix: build from checked-out source, not stale desktop copy#10

Merged
Akshat-Raj merged 1 commit intomainfrom
final
Mar 7, 2026
Merged

fix: build from checked-out source, not stale desktop copy#10
Akshat-Raj merged 1 commit intomainfrom
final

Conversation

@Akshat-Raj
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 7, 2026 03:18
@Akshat-Raj Akshat-Raj merged commit 548535f into main Mar 7, 2026
2 of 3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the ShieldCI GitHub Actions workflow to build and run from the checked-out source in $GITHUB_WORKSPACE instead of a stale copy assumed to exist at $HOME/Desktop/ShieldCI. It also moves hardcoded API credentials to GitHub Actions secrets and adds new steps for building the Kali Docker image and installing test dependencies.

Changes:

  • Replaced all $HOME/Desktop/ShieldCI path references with $GITHUB_WORKSPACE, ensuring the workflow operates on the checked-out repository source.
  • Moved SHIELDCI_API_URL and SHIELDCI_API_KEY from hardcoded values to ${{ secrets.* }} references, eliminating credential exposure.
  • Replaced the old "Copy shieldci.yml config" and "Copy target repo to engine" steps with "Build Kali Docker image" and "Install test app dependencies" steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants