Open
Conversation
Replaces the previous, less precise implementation of branch relaxation.
Contributor
|
Should we make an internship offer to make a formal proof of the fixpoint algorithm? This does not look so difficult but still interesting. |
Contributor
Author
|
There might be a verified branch relaxation pass in CakeML. See also https://arxiv.org/abs/1209.5920 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, the target of a conditional branch instruction is so far away that the displacement overflows the range of the instruction. As a workaround, the instruction can be rewritten as a negated conditional branch followed by an unconditional jump to the target. This rewriting is called branch relaxation.
Currently, branch relaxation is implemented for PowerPC only, in the powerpc/TargetPrinter.ml pass. The implementation is suboptimal in that code size computation assumes all branch instructions to be expanded.
This PR adds a generic implementation of branch relaxation in backend/Asmexpandaux.ml, with a more clever algorithm that assumes all branch instructions not expanded initially, and recomputes code size info when some branches are expanded, until reaching a fixed point.
This PR then instantiates the generic implementation
Branch relaxation is not currently implemented for the other CompCert targets: