Skip to content

Issue #2 Fix resolving directory of cli script so that symlinks actually work #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronMcHale merged 2 commits into from
Feb 27, 2026
Merged

Issue #2 Fix resolving directory of cli script so that symlinks actually work #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86416e9
Write test to proove symlink handling fails
AaronMcHale Feb 27, 2026
35c58c3
Fix failure
AaronMcHale Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Simple CLI wrapper that discovers scripts in the commands/ directory

# Cd to the directory of this script, so it can be run from anywhere
cd "$(dirname "$0")" || exit 1
cd "$(dirname "$(realpath "$0")")" || exit 1

# Color codes
RESET="\e[0m"
Expand Down
13 changes: 13 additions & 0 deletions tests/test-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ PROJECT_ROOT="$(dirname "$(dirname "$(realpath "$0")")")"
cleanup() {
rm "$PROJECT_ROOT/$TEST_CMD_PATH" || true
rm "$PROJECT_ROOT/$HELP_TXT_PATH" || true
rm "$PROJECT_ROOT/tests/cli-symlink.sh" || true
}
trap cleanup EXIT

Expand Down Expand Up @@ -45,6 +46,18 @@ cd ..
echo "OK"
echo

echo "Testing cli.sh as a symlink from tests directory, to proove that it can be run as a symlink from anywhere..."
cd tests
ln -s ../cli.sh ./cli-symlink.sh
OUT=$(./cli-symlink.sh)
if [[ "$OUT" != *"$TEST_CMD"* ]]; then
echo "FAIL: Test command $TEST_CMD not found when running cli.sh as a symlink from tests dir"
exit 1
fi
cd ..
echo "OK"
echo

echo "Testing cli.sh list sub-command to check output..."
OUT=$(./cli.sh list)
if [[ "$OUT" != *"$TEST_CMD"* ]]; then
Expand Down