Skip to content

fix: store original input_dump path in VerificationReport#75

Open
chaitanyamedidar wants to merge 1 commit intoAOSSIE-Org:mainfrom
chaitanyamedidar:fix/verify-input-dump-path
Open

fix: store original input_dump path in VerificationReport#75
chaitanyamedidar wants to merge 1 commit intoAOSSIE-Org:mainfrom
chaitanyamedidar:fix/verify-input-dump-path

Conversation

@chaitanyamedidar
Copy link

@chaitanyamedidar chaitanyamedidar commented Mar 14, 2026

Addressed Issues:

Fixes #74

Changes:
captured input_dump_original = str(input_dump) before resolving, and pass that to VerificationReport.

Screenshots/Recordings:

image

Additional Notes:

Checklist

  • My code follows the project's code style and conventions
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contributing Guidelines

⚠️ AI Notice - Important!

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.

Summary by CodeRabbit

  • Bug Fixes
    • Verification reports now preserve the original input representation instead of displaying the resolved path, improving report clarity and accuracy.

Copilot AI review requested due to automatic review settings March 14, 2026 17:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ac72c699-1aae-4782-a575-310b9bd54441

📥 Commits

Reviewing files that changed from the base of the PR and between c352df0 and ce7ce00.

📒 Files selected for processing (1)
  • openverifiablellm/verify.py

Walkthrough

The change preserves the original input_dump path string passed by the user instead of storing the resolved path in VerificationReport, fixing a Windows casing issue where Path.resolve() alters path casing through junction point expansion.

Changes

Cohort / File(s) Summary
Path String Preservation
openverifiablellm/verify.py
Capture the original input_dump string before path resolution and use it in VerificationReport to prevent Windows junction point expansion from altering path casing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Python Lang

Poem

🐰 A path once wandered, now preserved whole,
No junctions changing what was your soul,
The original string stays true and bright,
Windows casing troubles took flight!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly describes the main change: storing the original input_dump path instead of the resolved path in VerificationReport.
Linked Issues check ✅ Passed The code changes directly address issue #74 by capturing the original input_dump string before path resolution and passing it to VerificationReport, fixing the Windows path casing issue.
Out of Scope Changes check ✅ Passed The changes are minimal and focused solely on fixing the reported issue; no unrelated modifications are present in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Windows-specific path-casing bug in verify_preprocessing() by ensuring VerificationReport.input_dump preserves the caller-provided input_dump string rather than the Path.resolve()-normalized version.

Changes:

  • Capture input_dump_original = str(input_dump) before resolving the path.
  • Store input_dump_original in VerificationReport while still using the resolved Path for filesystem operations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions github-actions bot added size/XS and removed size/XS labels Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: verify_preprocessing() stores resolved path instead of original in VerificationReport

3 participants