fix(PC0013): resolve false positive for cross-table enum field access#170
Merged
Arthurvdv merged 1 commit intorelease/v0.6.1from Apr 1, 2026
Merged
fix(PC0013): resolve false positive for cross-table enum field access#170Arthurvdv merged 1 commit intorelease/v0.6.1from
Arthurvdv merged 1 commit intorelease/v0.6.1from
Conversation
Narrow IsFieldBasedOptionAccess() to only match Option fields, not Enum fields. Enum field-based member access (e.g., OtherTable.Field::Value) now falls through to AreFieldCompatible(), which correctly handles enum identity comparison via OriginalDefinition.Equals. This fixes a regression from 8202a13 where cross-table enum field access with the same underlying enum type was incorrectly flagged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow IsFieldBasedOptionAccess() to only match Option fields, not Enum fields. Enum field-based member access (e.g., OtherTable.Field::Value) now falls through to AreFieldCompatible(), which correctly handles enum identity comparison via OriginalDefinition.Equals.
This fixes a regression from 8202a13 where cross-table enum field access with the same underlying enum type was incorrectly flagged.